Skip to content

Incorrect handling of the "-" character on Seg7x4 displays #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wkuranowski opened this issue Jan 30, 2023 · 2 comments · Fixed by #112
Closed

Incorrect handling of the "-" character on Seg7x4 displays #111

wkuranowski opened this issue Jan 30, 2023 · 2 comments · Fixed by #112

Comments

@wkuranowski
Copy link
Contributor

The problem is located on the following line:

Adafruit_CircuitPython_HT16K33/adafruit_ht16k33/segments.py

Line 464 in 94453bf

character = 16

Offset 16 for the "-" character is no longer valid. The closest valid offset is 20, but I don't know if this is a correct solution.
@makermelissa
Copy link
Collaborator

You're right. It looks like this was caused by #109 which put a bunch of characters in front of the target character. It appears the "z" also took over the target character. I would add an additional character (so it won't accidentally have the formatting overwritten if somebody decides to make a z) and point it to that. So a new character would be 36 instead of 16.

@makermelissa
Copy link
Collaborator

Want to submit a PR?

@wkuranowski wkuranowski mentioned this issue Jan 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix incorrect handling of the "-" character on 7x4 segments
2 participants
@makermelissa @wkuranowski