Don't reset scroll index if loop is False #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we reset the scroll index, we keep looping because the scroll index (-1) isn't at the end of the text.
for ruff
FoamyGuy
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
@WanderingStar thanks for the fix!
Looks good to me. I verified the issue with loop=False, and this fix with a 14x4 segment feathwing and rp2040 feather.
|
Thanks. My tests were on a 1.2" 7-segment backpack and a Feather Huzzah 32 v2. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 16, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.6.14 from 4.6.13: > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#120 from WanderingStar/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we reset the scroll index, we keep looping because the scroll index (-1) isn't at the end of the text.