Auto-serve index.html for root path
#38
Conversation
|
This implementation defaults to One possible solution would be checking if the provided location is a folder, and if yes, then defaulting to It is also important to explain this behavoiur in docs. |
|
Maybe we want apache-style directory listing if there's no |
|
Personally, if we were talking about a Python lib, I would agree, but this one is for microcontrollers, often ones that do not have much storage and memory. Keeping that in mind, in my opinion, this lib should only provide enough functionality to easily spin up a HTTP server, without doing anything else. Nevertheless, it is up to the maintainers to decide. |
There was a problem hiding this comment.
This looks good to me. I tested successfully with a slightly modified simpletest on a feather TFT esp32s2.
I think it is probably best not to have the default behavior of file listing inside the library since it is intended for use in relatively minimal micro-controller environments.
However I do also think it could make a good example script if someone wanted to implement the functionality and share it for folks who might be interested in it.
Thank you @matemaciek
Updating https://github.com/adafruit/Adafruit_CircuitPython_DotStar to 2.2.6 from 2.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_DotStar#62 from tlyu/zero-trailer > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_IS31FL3741 to 1.4.0 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_IS31FL3741#22 from FoamyGuy/py_driver_pixelbuf > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP9808 to 3.3.19 from 3.3.18: > Merge pull request adafruit/Adafruit_CircuitPython_MCP9808#36 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.11.0 from 3.10.19: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#110 from makermelissa/master > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7735R to 1.5.10 from 1.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_ST7735R#30 from makermelissa/master > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.19.13 from 1.19.12: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#80 from jposada202020/updating_examples Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 2.3.0 from 2.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#37 from matemaciek/main > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#38 from matemaciek/patch-1 > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
No description provided.