_read_channel_raw fix, longint support #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Dec 9, 2024
|
I tested the updated library and found that the values it outputs are now comparable to the ones output by the Arduino library, and that it does initialize and read values successfully now on a build without longint. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 13, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.3.5 from 3.3.4: > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#45 from jposada202020/adding_displayio_example Updating https://github.com/adafruit/Adafruit_CircuitPython_HX711 to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_HX711#3 from FoamyGuy/longint_support Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8523 to 2.0.3 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8523#34 from jposada202020/adding_displayio_example Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 3.1.3 from 3.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#44 from FoamyGuy/circle_and_dot_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Resolves: #2
Discussed this change on discord with @jepler: https://discord.com/channels/327254708534116352/327298996332658690/1315814085803249724
It seems the code using the longint wasn't correct for the given MIN and MAX values from the datasheet. The corrected code doesn't make use of longint.
I tested importing this modified library on a device without longint to confirm it no longer raises the overflow error.
Sensor is otw and I will test initializing and reading data once it arrives.