Add PyPi #3
Add PyPi #3
Conversation
There was a problem hiding this comment.
Everything in the .travis.yml looks fine. However, I went to peek at setup.py and noticed this:
install_requires=[
'Adafruit-Blinka',
'ESP32SPI'
],
Shouldn't ESP32SPI be adafruit-circuitpython-esp32spi? I imagine the pip install would fail otherwise for the requirement.
EDIT: also, looked in requirements.txt just now. SimpleIO is also used, so adafruit-circuitpython-simpleio should be added to the install_requires list.
Which brings me to another question: couldn't usage on a Blinka implementation that has on-board WiFi (e.g. RPi 0w) fail on instantiation? The current code forces an external ESP (32 or AT) module. This second part may be better as an issue, so feel free to move it there to address later. This may also be a larger Blinka thing, as well.
I believe it would fail.. ESP32SPI_WiFiManager would need to be replaced with @sommersoft Requirements have been changed per your review. |
I'll go ahead and merge this, but I feel like this should be addressed soon. I don't see many users that will want to use an external ESP with this on any SBCs supported by Blinka. Granted, there are also a myriad of Hue libraries available on PyPI already, so that could offset... |
Addressing #2 (comment)