Skip to content

Fix Channel code in wrong class #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix Channel code in wrong class #3

wants to merge 9 commits into from

Conversation

BZab
Copy link

@BZab BZab commented Jan 10, 2025

No description provided.

@bablokb
Copy link
Contributor

bablokb commented Apr 7, 2025

Just noticed your PR. I also created a PR that changes and fixes more things, you might want to have a look.

It is a pity that this repo seems to be more or less dead.

@BZab
Copy link
Author

BZab commented Apr 7, 2025

I just needed a code that works. My fork wasn't intensively tested; I wouldn't be surprised to see some other bugs getting discovered once the libraries, depending on this fork, get more use, and so does the IC (rather than being configured in a way that it won't disturb the development of other stuff).

Feel free to merge the changes I made. It would make sense to have a single, reliable library that 'just works' and properly supports the IC's features, whether an official one or an independent one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants