fix padded pbm binary loading #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossless
commented
Apr 9, 2025
7b53343 to
8ddd37d
Compare
8ddd37d to
23f7866
Compare
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 19, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV320 to 1.0.1 from 1.0.0: > make speaker louder by default > Update README.rst Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 1.24.2 from 1.24.1: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#100 from carlossless/binary-pbm-width-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_PIO_UART to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_PIO_UART#6 from burtyb/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_USB_Host_Descriptors to 0.2.3 from 0.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_USB_Host_Descriptors#6 from FoamyGuy/update_two_mice_example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some of my binary PBM files were failing to load because they appeared to have more pixel bits than the size header indicated — even though they opened and displayed fine in tools like macOS Preview.app.
After digging a bit, I found that for images with widths that aren't a multiple of 8 (i.e., not aligning to a full byte), the remaining bits are padded. Turns out, this is expected behavior per the PBM format spec.
This change updates the loader to ignore those padding bits.