Skip to content

Update type annotations for itertools extras. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2024
Merged

Update type annotations for itertools extras. #25

merged 2 commits into from
Apr 29, 2024

Conversation

kbsriram
Copy link
Contributor

  • Fixed a small bug with all_equal() on empty inputs.
  • Fixed a documentation bug with pairwise().
  • Added tests for all methods.
  • Verified mypy --warn-unused-ignores --disallow-untyped-defs runs successfully on tests.

Fixes #12

@kbsriram
Update type annotations for itertools extras.
088e246 
- Fixed a small bug with all_equal() on empty inputs.
- Fixed a documentation bug with pairwise().
- Added tests for all methods.
- Verified mypy --warn-unused-ignores --disallow-untyped-defs runs
  successfully on tests.

Fixes adafruit#12
@kbsriram kbsriram marked this pull request as draft April 29, 2024 05:53
@kbsriram
Include more-itertools in optional_requirements
3bd2dd9 
This is only used in tests, for comparison.
@kbsriram kbsriram marked this pull request as ready for review April 29, 2024 07:03
FoamyGuy
FoamyGuy approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you @kbsriram!

I tested the simpletest successfully on a feather S3 TFT. I also confirmed the behavior of pairwise() that the docstring was updated for. I confirmed the behavior of CPython all_equal() as well.

@FoamyGuy FoamyGuy merged commit a77ae43 into adafruit:main Apr 29, 2024
1 check passed
@kbsriram kbsriram deleted the add-types-3 branch April 29, 2024 16:09
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 30, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@38b61d2)
387e892 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ConnectionManager to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ConnectionManager#15 from justmobilize/update-docs

Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 2.1.1 from 2.1.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#25 from kbsriram/add-types-3
  > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#24 from kbsriram/add-types-2

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#63 from kbsriram/add-out-tests

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@kbsriram @FoamyGuy