Add headers parameter to generate() #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
headers parameter allows optional headers to be set on generated JWT such as "kid".
|
@jay0lee Thanks for the PR, looks like the action is failing here: https://github.com/adafruit/Adafruit_CircuitPython_JWT/pull/8/checks?check_run_id=1596851924#step:12:8 I'll review once it's passing. |
|
Thanks @brentru I was just looking into those. Glad to add a fix here but as far as I can tell Actions haven't run in 6 months and these are new PyLint warnings unrelated to my changes. Again, I'll see what I can do to solve them but it might also be worth scheduling a GitHub Actions run every week or so and not just on PRs. |
|
OK, tests are all green now. |
brentru
approved these changes
Dec 23, 2020
|
Looks good, thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 24, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_JWT to 1.2.0 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_JWT#8 from jay0lee/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#5 from slootsky/feature/get_local_time_ignores_location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dict headers parameter to generate() so that additional headers like
kidcan be added.kidis needed for Google's service account JWT authentication.