rainbowcomet: add missing arg initing base class #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In RainbowComet, the call to `super().__init__()` was missing the `background_color` argument. This caused strange effects when non-default arguments were passed. For example, setting `reverse=True` resulted a red comet with a tail length of 1, and setting `bounce=True` resulted in a reversed rainbow comet. Signed-off-by: Taylor Yu <code@argon.blue>
|
Good catch! It looks like that argument is typically |
|
I think so. It should take any input that is acceptable as an element of the contained pixels object, which I believe includes |
tekktrik
approved these changes
Jan 24, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 24, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.13 from 4.1.12: > Add upload url to release action > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#61 from tekktrik/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP3xxx to 1.4.14 from 1.4.13: > Merge pull request adafruit/Adafruit_CircuitPython_MCP3xxx#40 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_PCD8544 to 1.2.13 from 1.2.12: > Merge pull request adafruit/Adafruit_CircuitPython_PCD8544#17 from tcfranks/main > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.7.0 from 0.6.5: > Add upload url to release action > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#43 from adafruit/pca9546a_update > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.13.5 from 1.13.4: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#88 from e28eta/patch-1 > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_AzureIoT to 2.5.13 from 2.5.12: > Merge pull request adafruit/Adafruit_CircuitPython_AzureIoT#56 from MathCatsAnd/ssl-compatibility > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.4 from 2.6.2: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#108 from tlyu/rainbowcomet-init > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#109 from tlyu/comet-doc > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 2.2.4 from 2.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#90 from FoamyGuy/pin_alarm_example > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In RainbowComet, the call to
super().__init__()was missing thebackground_colorargument. This caused strange effects when non-default arguments were passed.For example, setting
reverse=Trueresulted a red comet with a tail length of 1, and settingbounce=Trueresulted in a reversed rainbow comet.