Add support for OpenMV/MicroPython #126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would rather not support MicroPython directly in the library. It takes up more space, which can be tight on some boards, and it also makes us responsible for maintenance of this feature. Creating your own fork makes sense. Another idea is to make a |
|
Will fork, thanks for the feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MicroPython has a
neopixellibrary, but it's functionality is not as robust as CircuitPythons:https://docs.micropython.org/en/latest/library/neopixel.html
In our situation, we had a project which required an OpenMV board, which runs MicroPython instead of CircuitPython. In this case, OpenMV has their own fork of MicroPython, which has a similar
neopixellibrary:https://docs.openmv.io/library/neopixel.html
This PR allows the
Adafruit_CircuitPython_LED_Animationto work with theneopixellibrary from OpenMV's fork of MicroPython.However, given "CircuitPython" is in the name of this library, I'm uncertain if it makes sense to merge this PR .. or create a dedicated fork for OpenMV MicroPython?