Skip to content

Add Missing Type Annotations #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 29, 2022
Merged

Add Missing Type Annotations #9

merged 4 commits into from
Sep 29, 2022

Conversation

tcfranks
Copy link
Contributor

resolves #8
submitted for review / comment

@tekktrik tekktrik requested a review from a team September 16, 2022 14:26
tekktrik
tekktrik requested changes Sep 25, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great submission! There was an interesting case of how to type chip_id here! Feedback below:

tekktrik
tekktrik requested changes Sep 27, 2022
View reviewed changes
@tcfranks
Copy link
Contributor Author

changes for chip_id and other review comments submitted for review

tekktrik
tekktrik approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@tekktrik tekktrik merged commit c99a65c into adafruit:main Sep 29, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 29, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eaa233b)
abf0326 
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS2413 to 1.2.14 from 1.2.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_DS2413#24 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.2.8 from 2.2.7:
  > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#19 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_LPS2X to 2.0.12 from 2.0.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_LPS2X#9 from tcfranks/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @tekktrik