Skip to content

Add Missing Type Annotations #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 21, 2022
Merged

Add Missing Type Annotations #14

merged 5 commits into from
Nov 21, 2022

Conversation

tcfranks
Copy link
Contributor

resolves #11
submitted for review / comment

tekktrik
tekktrik requested changes Oct 30, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Feedback below:

@tcfranks
Copy link
Contributor Author

resubmitted for review / comment

FoamyGuy
FoamyGuy approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @tcfranks!

@FoamyGuy FoamyGuy merged commit 92f8966 into adafruit:main Nov 21, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 22, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@a295390)
cd569a1 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP4728 to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MCP4728#14 from tcfranks/main
  > Update .pylintrc for v2.15.5
  > Fix release CI files
  > Update pylint to 2.15.5
  > Updated pylint version to 2.13.0
  > Switching to composite actions

Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel to 6.3.7 from 6.3.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#143 from kattni/rainbowio-simpletest
  > Merge pull request adafruit/Adafruit_CircuitPython_NeoPixel#141 from tekktrik/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.12.11 from 1.12.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#121 from DJDevon3/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik requested changes

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
3 participants
@tcfranks @FoamyGuy @tekktrik