lower cell_padding in the grid example #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
approved these changes
Sep 1, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 3, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.0.2 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#29 from FoamyGuy/grid_example_cell_padding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a tweak to lower the cell padding in the grid example to account for a fix inside of GridLayout from DisplayIO_Layouts PR #48
If that PR is merged as it is now this should be merged at the same time to account for a difference in the way that labels are positioned.
Using the version of GridLayout in that PR along with this change this example should appear roughly the same on the screen as the current version does now with the currently released version of GridLayout
here is how the example looks on the display using the updated code from that PR and this change:
