Updated documentation to include missing dependency #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Feb 26, 2022
There was a problem hiding this comment.
Thanks! As you saw, adafruit_debouncer depends on adafruit_ticks, so it's a transitive dependency.
I removed some blank lines that were making the build fail. You can use pre-commit to check for this in the future. See https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code and the rest of that guide.
|
@dhalbert - would using the circup utility resolve dependancies that are transitive? |
|
Yes. Here I deleted everything in the CIRCUITPY $ circup install adafruit-circuitpython-macropad
Found device at /media/halbert/CIRCUITPY, running CircuitPython 7.2.0.
Searching for dependencies for: ['adafruit-circuitpython-macropad']
Ready to install: ['adafruit_bitmap_font', 'adafruit_debouncer', 'adafruit_display_text', 'adafruit_hid', 'adafruit_macropad', 'adafruit_midi', 'adafruit_pixelbuf', 'adafruit_simple_text_display', 'adafruit_ticks', 'neopixel']
Installed 'adafruit_bitmap_font'.
Installed 'adafruit_debouncer'.
Installed 'adafruit_display_text'.
Installed 'adafruit_hid'.
Installed 'adafruit_macropad'.
Installed 'adafruit_midi'.
Installed 'adafruit_pixelbuf'.
Installed 'adafruit_simple_text_display'.
Installed 'adafruit_ticks'.
Installed 'neopixel'.Also if you "Download Project Bundle" from a Learn Guide page, it will also include all dependencies, including transitive ones. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 2, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.3.1 from 4.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#50 from myllyja/fix-lsm6ds3trc Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.7 from 1.10.6: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#96 from ladyada/main > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.4.2 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#27 from tekktrik/fix-example-file Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 0.5.7 from 0.5.6: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#20 from dhalbert/_asyncio > Fixed readthedocs build Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 2.0.6 from 2.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#38 from xelwarto/main > Fixed readthedocs build > Post-patch cleanup > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.2.3 from 5.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#104 from fabaff/permission
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While getting started with the MacroPad I found that use of the macropad library also required the adafruit_ticks library which was not documented as a dependency.