Made library work when internet is not connected #21
Conversation
|
I am very much interested into this kind of option. |
|
Hi, thanks for this PR. I'm trying to understand the main functions you would like out of the top level matrixportal library (which was intended to tie the network and graphics stuff together) that don't use network? Since this PR goes against the intention of this class, I would like to understand your needs better (both @dherrada and @dglaude). Most likely the functions you require should probably be moved down to the graphics layer, which is the correct approach and then you could just use that. It would result in less memory usage as well. |
|
Also, if it's helpful, here's a diagram of the layout of the library: |
|
I’ve been using just the Matrix side of MatrixPortal (see Creature Eyes guide) as-is, doesn’t require invoking Network. |
|
@PaintYourDragon Thanks, I'll take a look at that. |
|
@makermelissa Ah, ok. That makes sense. |
In my dorm, there isn't really any way to connect my MatrixPortal to the internet (VT uses an enterprise network). I still wanted to make use of this library, so I added a new parameter to the matrixportal constructor that lets you specify when you don't want to connect to internet. It would be really great if someone could make sure this still works when you're connecting to internet, since that's not something I can test