Skip to content

Accept width & height to pass through to the Graphics constructor. #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 26, 2020
Merged

Accept width & height to pass through to the Graphics constructor. #32

merged 2 commits into from
Oct 26, 2020

Conversation

dastels
Copy link
Collaborator

@dastels dastels commented Oct 25, 2020

Two new keyword arguments for MatrixPortal.init that get passed to the Graphics constructor call.

@dastels dastels requested a review from makermelissa October 25, 2020 23:09
@dastels dastels requested a review from caternuson October 25, 2020 23:25
makermelissa
makermelissa approved these changes Oct 26, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@makermelissa makermelissa merged commit a093fc6 into adafruit:master Oct 26, 2020
@makermelissa makermelissa mentioned this pull request Oct 26, 2020
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 27, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c01bb3a)
6bde03f 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.8.3 from 1.8.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#33 from adafruit/bigscroll
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#32 from dastels/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_LC709203F
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

@caternuson caternuson Awaiting requested review from caternuson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dastels @makermelissa