Skip to content

Add use-wifi param #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Conversation

justmobilize
Copy link
Contributor

@justmobilize justmobilize commented May 30, 2024

This fixes #85 by allowing the user to specify they don't want to use WiFi. A later PR could happen that enables Bluetooth.

@rebtop
Copy link

rebtop commented May 30, 2024

Justin, Yes, Please let me know when i can try it.

@justmobilize
Copy link
Contributor Author

@rebtop you can download the files from here: https://github.com/justmobilize/Adafruit_CircuitPython_MatrixPortal/tree/add-use-wifi-param and replace what you have in lib/adafruit_matrixportal with what's in the adafruit_matrixportal from the download.

Then when you create it add use_wifi:

matrixportal = MatrixPortal(
    # what ever you have currently
    use_wifi=False,
)

@rebtop
Copy link

rebtop commented May 31, 2024 via email

@rebtop
Copy link

rebtop commented Jun 1, 2024

Justin
I downloaded 3 files. Matrix.py, matrixportal.py and network.py.
in which file does the code you gave belong?
In the matrixportal.py i see if use_wifi: .....
Can you give me the file and line number for reference?

@rebtop
Copy link

rebtop commented Jun 1, 2024

I am assuming you want this inserted in the code itself. I will try that.

@rebtop
Copy link

rebtop commented Jun 1, 2024

That change takes the incompatibility out of play. Now i will work on getting Ble to work.

@justmobilize
Copy link
Contributor Author

@rebtop awesome!

@justmobilize justmobilize marked this pull request as ready for review June 1, 2024 19:32
@rebtop
Copy link

rebtop commented Jun 1, 2024

K Ble is working with MatrixPortal code.
Justin, great job

@justmobilize
Copy link
Contributor Author

Awesome. If you are willing to share code, I can use it as a basis to build in Bluetooth support into MatrixPortal

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justmobilize for the PR and @rebtop for testing.

@dhalbert dhalbert merged commit 502af36 into adafruit:main Jun 2, 2024
1 check passed
@justmobilize justmobilize deleted the add-use-wifi-param branch June 2, 2024 04:14
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 2, 2024
@rebtop
Copy link

rebtop commented Jun 2, 2024 via email

@rebtop
Copy link

rebtop commented Jun 4, 2024

I am cleaning up the code and will share it shortly

@rebtop
Copy link

rebtop commented Jul 3, 2024

Justin
Been away and finally have a short script for you that works
M4 Matrixportal code with WIFI
m4_one_input_ble.docx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BLE support to the library
3 participants