make user_data "public" #188
Conversation
There was a problem hiding this comment.
This looks good to me. Thank you @vladak.
I do agree with the overall premise that it would be ideal if the on_message() callback matched the signature of all the other callbacks with regards to getting user data passed to it. It stands out as a discrepancy amongst the different callbacks.
Honestly I think in the long term I'd be okay with a breaking change that added it as as the second argument so that the callbacks would match signatures from then on. If you're interested in potentially moving that direction maybe it's worth dropping a note in the meeting doc to discuss it in the weeds to get thoughts from the wider team and community.
I tested this version successfully on a FunHouse device with a slightly modified simpletest using some of the code in the new user_data example.
Updating https://github.com/adafruit/Adafruit_CircuitPython_HUSB238 to 1.0.1 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_HUSB238#3 from millercommamatt/patch-2 > example typo Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM69 to 2.1.18 from 2.1.17: > Merge pull request adafruit/Adafruit_CircuitPython_RFM69#48 from jerryneedell/jerryn_power Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.5.3 from 7.4.4: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#186 from vladak/var_header_vs_bytearray > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#183 from vladak/wait_for_msg_pkt_type > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#182 from vladak/time_monotonic_ns > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#188 from vladak/user_data_public Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
This change makes using
user_datamore accessible for received message callbacks.