handle partial socket send()'s #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The patch you sent me seems to be working well. Thank you so much for your help, you saved my day! |
brentru
approved these changes
Jan 2, 2025
|
|
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 3, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90393 to 2.3.1 from 2.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90393#45 from FoamyGuy/reset_sleep_ms Updating https://github.com/adafruit/Adafruit_CircuitPython_MPRLS to 1.2.20 from 1.2.19: > Merge pull request adafruit/Adafruit_CircuitPython_MPRLS#20 from FoamyGuy/type_annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_PCF8575 to 1.0.7 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_PCF8575#8 from FoamyGuy/value_return_bool Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.4.15 from 1.4.14: > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#34 from FoamyGuy/min_delay_continuous Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.11.0 from 7.10.5: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#232 from vladak/send_bytes_eagain > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#226 from vladak/connect_session_id > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#229 from manchicken/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#231 from dhalbert/partial-send
This was referenced Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The library was using
socket.send()directly, but not checking the return value to see if all the bytes were sent. So for larger packets, a partial send would go unnoticed. Added_send_bytes(), which callssend()until all bytes are sent, and also handlesEAGAIN. I could have usedsocket.sendall(), but it doesn't handle EAGAIN.I tested by sending 2900-byte packets to a no-history Adafruit IO test feed. @manchicken, who submitted #230, also tested.