MQTT QOS=1,2 rules state that pid must be > 0. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlizotte-uwo I tested and verified on wireshark that the packet identifier for pub/sub is => 1 when qos >1, also checked fields for anything malformed. Looks good:
I'm ok with wrapping to 1, thank you for handling this edge case. |
brentru
approved these changes
Apr 5, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 6, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.0.7 from 5.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#79 from dlizotte-uwo/master
rtwfroody
pushed a commit
to rtwfroody/Adafruit_CircuitPython_MiniMQTT
that referenced
this pull request
Sep 18, 2022
MQTT QOS=1,2 rules state that pid must be > 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publishing with QOS 1 seemed to be broken because PID was incremented immediately after putting into packet, meaning that the PUBACK packet would not match the new (incremented) PID.
There is a danger if publishing more than 0xFFFF packets that .to_bytes will fail because it can't pack into 2 bytes after that. PID must wrap around to 1, not 0, according to spec, which demands that PID be nonzero for QOS 1 and 2.