Fix error caused by non-existent variable_frequency property #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was addressing #66 with that commit I believe. |
Ok yeah, a try/except should work more consistently to see if variable_frequency is indeed enabled.
I think Scott meant, he didn't know why you used |
tekktrik
approved these changes
Feb 4, 2023
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 5, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME680 to 3.4.12 from 3.4.11: > Merge pull request adafruit/Adafruit_CircuitPython_BME680#58 from tekktrik/dev/add-opp-deps > Add upload url to release action > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.2.7 from 1.2.6: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#35 from Neradoc/documentation-for-raw-text-packet > Add upload url to release action > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.4.8 from 3.4.7: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#70 from makermelissa/master > Add upload url to release action Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in regards to https://forums.adafruit.com/viewtopic.php?p=958532.
This fixes an issue introduced by #67 because the
variable_frequencyis not a property of PWMOut according to https://docs.circuitpython.org/en/latest/shared-bindings/pwmio/index.html nor is it a property of the Seesaw PWMOut which is used on the Raspberry Pi. I'm not sure if it exists in certain instances, so I just added a check if it has the attribute before trying to use it.