Fixed hanging by adding socket_timeout parameter with a default timeout of 10s #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladyada
approved these changes
Aug 13, 2022
tannewt
approved these changes
Aug 15, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 16, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.2.7 from 5.2.6: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#120 from dhalbert/no-pwmout-for-pulseout Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.8 from 4.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#54 from dhalbert/no-pwmout Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31856 to 0.11.0 from 0.10.1: > Merge pull request adafruit/Adafruit_CircuitPython_MAX31856#20 from eirinnm/selectable_mains_filtering Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 6.2.6 from 6.2.5: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#123 from dhalbert/no-auto-brightness Updating https://github.com/adafruit/Adafruit_CircuitPython_TFmini to 1.2.12 from 1.2.11: > Merge pull request adafruit/Adafruit_CircuitPython_TFmini#13 from okennedy/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.0.4 from 3.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#22 from regulatre/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.0 from 1.13.6: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#78 from colonwq/is_connected Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.5.9 from 2.5.8: > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#36 from dhalbert/no-auto-brightness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inevitably network connections will let us down and reads will fail. To prevent indefinite hanging in this situation we can now rely on a default read timeout of 10s. The default value can also be overridden by instantiating the class with the new value specified as socket_timeout. Credit to @mattura for the suggestion.