Skip to content

Example should be renamed to include simpletest #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kattni opened this issue Sep 30, 2019 · 5 comments
Closed

Example should be renamed to include simpletest #12

kattni opened this issue Sep 30, 2019 · 5 comments
Labels
good first issue Hacktoberfest

Comments

@kattni
Copy link
Contributor

kattni commented Sep 30, 2019 •
edited
Loading

Example onewire_demo.py should be renamed to onewire_simpletest.py to fit with CircuitPython library standards.

The lines including this file name in the docs/examples.rst file must also be updated to reflect the name change, e.g.:

.. literalinclude:: ../examples/current_file_name.py
    :caption: examples/current_file_name.py
    :linenos:

would be updated to:

.. literalinclude:: ../examples/current_file_name_changed.py
    :caption: examples/current_file_name_changed.py
    :linenos:
@sreekaransrinath
Copy link
Contributor

Hey, I'd like to take this issue up!

sreekaransrinath added a commit to sreekaransrinath/Adafruit_CircuitPython_OneWire that referenced this issue Oct 1, 2019
@sreekaransrinath
Rename onewire_demo.py to onewire_simpletest.py
680dc4c 
Fixed issue adafruit#12
@sreekaransrinath sreekaransrinath mentioned this issue Oct 1, 2019
Merged
@ladyada
Copy link
Member

ladyada commented Oct 1, 2019

go for it!!! 🎃

@sreekaransrinath
Copy link
Contributor

Yeah, I finished it right after I commented :)

@shlok-goud
Copy link

Hi. I would like to take up this issue for my first pull requests.

@ladyada
Copy link
Member

ladyada commented Oct 12, 2019

@shlok-goud oops this was already done
#13
we have lots more hacktober PRs very similar to this one!

@ladyada ladyada closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ladyada @kattni @sommersoft @shlok-goud @sreekaransrinath