Skip to content

tests may not cover 'out' instruction? #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jepler opened this issue Apr 26, 2022 · 0 comments · Fixed by #63
Closed

tests may not cover 'out' instruction? #44

jepler opened this issue Apr 26, 2022 · 0 comments · Fixed by #63
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jepler
Copy link
Contributor

jepler commented Apr 26, 2022 •
edited
Loading

While working on #43 I learned that my early implementation of 'out' was wrong, even after the tests passed. Is there no/inadequate coverage of 'out' in the existing tests? Add tests for several 'out' instructions with manually-verified results.
@jepler jepler added bug Something isn't working good first issue Good for newcomers labels Apr 26, 2022
@adafruit-adabot adafruit-adabot added the Hacktoberfest DigitalOcean's Hacktoberfest label Sep 29, 2022
@dhalbert dhalbert removed the Hacktoberfest DigitalOcean's Hacktoberfest label Mar 25, 2024
kbsriram added a commit to kbsriram/Adafruit_CircuitPython_PIOASM that referenced this issue Apr 26, 2024
@kbsriram
Add tests for "out" and "in".
d87b446 
Also added more descriptive errors for invalid
source/destination values.

Fixes adafruit#44
@kbsriram kbsriram mentioned this issue Apr 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for "out" and "in". kbsriram/Adafruit_CircuitPython_PIOASM
3 participants
@jepler @dhalbert @adafruit-adabot