Skip to content

Conversation

burtyb
Copy link
Contributor

@burtyb burtyb commented Apr 23, 2025

I've tested it with flow control enabled against itself on another Pico, the hardware UART on another Pico and an FTDI breakout (which sometimes sends 2 bytes after RTS# is taken high).

I've also updated the "line by line" description to more match the PIO code as it looks like it was originally written against code based on the "uart_rx_mini" example.

@burtyb
Copy link
Contributor Author

burtyb commented Apr 24, 2025

I'm not sure if the failed "black" check is OK or not as I just tagged onto the end?

Also to use it you'll need a CircuitPython which incorporates adafruit/circuitpython#10262

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will want to update the formatting to make black happy. Installing pre-commit locally is the easiest way to do it.

Everything else looks fine. Thanks for adding this!

@burtyb
Copy link
Contributor Author

burtyb commented Apr 24, 2025

Updated, it was all on one line originally so I didn't know if I should mess with it or not :).

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We let the formatter decide things like that. :-)

@tannewt tannewt merged commit 9225d09 into adafruit:main Apr 24, 2025
1 check passed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Apr 29, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV320 to 1.0.2 from 1.0.1:
  > check for built-in i2s in example

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIO_UART to 1.1.0 from 1.0.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIO_UART#7 from burtyb/hardware_flow_control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants