Lazily parse secrets data #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Looks good to me, though it's been so long since I worked on this and it's been modified quite a bit since that I can't even remember how it used to work. I didn't test, though I have no reason to believe it wouldn't work. My main concern is if changes break/fix compatibility with existing code and from reading notes it sounds like this is supposed to fix compatibility.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 27, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_GUVX_I2C to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_GUVX_I2C#3 from sokratisvas/add-type-annotations Updating https://github.com/adafruit/Adafruit_CircuitPython_INA219 to 3.4.20 from 3.4.19: > Merge pull request adafruit/Adafruit_CircuitPython_INA219#34 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.3.10 from 1.3.9: > Merge pull request adafruit/Adafruit_CircuitPython_INA260#20 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD30 to 2.2.9 from 2.2.8: > Merge pull request adafruit/Adafruit_CircuitPython_SCD30#32 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1327 to 1.3.9 from 1.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1327#16 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.1.15 from 1.1.14: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#13 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 1.0.12 from 1.0.11: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#8 from tcfranks/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.3 from 1.14.2: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#80 from tekktrik/bugfix/multiple-networks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #79 by moving the parsing of the secrets data to
connect(). This allows for initialization of the MagTag object when a non-standardsecretsdictionary is given. This is done when an alternative way of connecting to WiFi besides the MagTag-specificconnect()is desired (such aswifi.radio.connect()). This was valid functionality before #, and this just restores it.Have not tested.