rename _width and _height attributes #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tannewt merged 2 commits into adafruit:master from mtowara:mtowara-patch-1

Oct 26, 2020

Contributor

mtowara commented Oct 22, 2020

fix for #17


          rename _width and _height attributes

17d33fc

fix for adafruit#17

tannewt requested changes

View reviewed changes

Member

tannewt left a comment

Please add a comment before self._bar_width so that someone doesn't change it back. Thanks!


          Update adafruit_progressbar.py

f6a9b8e

add requested comment

mtowara requested a review from tannewt

October 22, 2020 22:40

Contributor

FoamyGuy commented Oct 23, 2020

Thank you for this fix @mtowara

I can test this with Blinka_Displayio and on a microcontroller device later on tonight.

FoamyGuy approved these changes

View reviewed changes

Contributor

FoamyGuy left a comment

I tested these changes successfully with a RasPi 3B+ with TFT Screen hat. Also confirmed no change to behavior on PyPortal.

tannewt approved these changes

View reviewed changes

Member

tannewt left a comment

Looks good! Thank you!

tannewt merged commit f149b60 into adafruit:master

FoamyGuy mentioned this pull request

width and height attributes clash with Tilegrid #17

Closed

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@c01bb3a)

d5a7809

Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.1 from 5.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#57 from markus-k/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.2 from 3.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#112 from tannewt/return_earlier
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#111 from adafruit/rssi_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.1 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#12 from tannewt/grayscale

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.2.5 from 2.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#23 from ben-lewis/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 1.2.0 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#7 from markus-k/reg-addr

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#18 from mtowara/mtowara-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.9.1 from 1.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#40 from AdamCummick/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.3 from 1.7.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#43 from makermelissa/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet