Business card update #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makermelissa
requested changes
Jul 3, 2019
| @@ -61,17 +61,17 @@ from adafruit_pybadger import PyBadger | |||
| pybadger = PyBadger() | |||
|
|
|||
| while True: | |||
| pybadger.show_badge(hello_scale=2, my_name_is_scale=2, name_scale=3) | |||
| pybadger.show_badge(name_string="Blinka", hello_scale=2, my_name_is_scale=2, name_scale=3) | |||
There was a problem hiding this comment.
I would recommend moving show_badge and auto_dim out of the loop and then allowing something like pressing the start button to switch back to badge mode.
adafruit_pybadger.py
Outdated
| email_label.color = 0xFFFFFF | ||
| email_group.append(email_label) | ||
| business_card_splash.append(email_group) | ||
| time.sleep(dwell) |
There was a problem hiding this comment.
I'm not entirely sure of the point of the automatically sleep for 20 seconds is. If this is for the purposes of the simepletest, would it be more useful to put it in the simpletest itself?
There was a problem hiding this comment.
I realised earlier that I need to make the code non-blocking, but didn't have the time to do so yet. Please do not merge until I have done that - I'll get to it this evening.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 11, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.4.3 from 1.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#60 from brentru/make-esp-object-public Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.8.0 from cf55921: < Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#3 from kattni/business-card-update Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_PyBadger
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 12, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 1.5.0 from 1.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#29 from martymcguire/mm-chunk-socket-sends Updating https://github.com/adafruit/Adafruit_CircuitPython_SI4713 to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_SI4713#7 from caternuson/iss2_rds Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Button to 1.1.2 from 1.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Button#8 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 0.9.0 from 0.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#3 from kattni/business-card-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added email display functionality to
show_business_card, and changeddatainshow_qr_codeto a string from a bytearray. Updated examples to be accurate and more thorough.