Handle app/javascript as json. Fix missing text position error #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ladyada merged 2 commits into adafruit:master from makermelissa:master

Nov 3, 2020

+8 −5

Collaborator

makermelissa commented Nov 3, 2020

Fixes #90. This also fixes an issue with the Tides example that wasn't working.

makermelissa added 2 commits

November 3, 2020 10:23


          Handle app/javascript as json. Fix missing text position error

a69f2a9


          Black formatted

1dcd993

makermelissa requested a review from a team

November 3, 2020 18:27

Member

ladyada commented Nov 3, 2020

@joelguth wanna try ?

joelguth commented Nov 3, 2020

Looks good! No errors with the new adafruit_pyportal.py library.

Member

ladyada commented Nov 3, 2020

yay thank you for testing :)

ladyada merged commit 4ffb7bf into adafruit:master

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request


          Automated update by Adabot (adafruit/adabot@c01bb3a)

8fe08c6

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.6.1 from 3.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#91 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.0.2 from 2.0.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#27 from makermelissa/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet