Initial commit for comment and review #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2024
tannewt
requested changes
Aug 5, 2024
tannewt
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first commit of the combined library for RFM69/RFM9X for comment/review -- I expect there will be significant changes to be made.
New features:
Uses asyncio internally - may also be used in user code.
Radiohead Header may be disabled for compatibility with other libraries.
FSK/OOK support added to RFM9x
RFM9X can communicate with RFM69 in FSK/OOK (without encryption)
Addressing may be enabled for FSK/OOK on RFM69/RFM9x
There are several examples provided -- more to come.
Please take a look at the overall structure and coding and comment/review.
Note: this cannot not be used on the Feather M0 RFM69/9X boards
requires RP2040 or RFM featherwing/breakout on a MCU with more resources than an M0
It does work on a Raspberry Pi with the RFM bonnet --
most of the testing has been on an RPi with a RFM bonnet (RFM95 and RFM69)
and on a feather esp32s2 with an RFM95 Featherwing
In the examples, you can uncomment 2 lines to select RFM69, RFM9x or RFM9XFSK operation