Move asserion of length of data packet #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me - Thank you! I tried this PR on a Feather_RP2040_RFM95 and on a Raspberry Pi 5 with some existing code and it still works normally. I did not explicitly test the assert. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jul 8, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_EPD to 2.13.6 from 2.13.5: > Merge pull request adafruit/Adafruit_CircuitPython_EPD#91 from adafruit/ssd1680_tricolor Updating https://github.com/adafruit/Adafruit_CircuitPython_RFM to 1.0.7 from 1.0.6: > Merge pull request adafruit/Adafruit_CircuitPython_RFM#15 from hrfarmer/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1305 to 1.4.3 from 1.4.2: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1305#18 from mikeysklar/128x64-spi-col-offset Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1680 to 2.0.4 from 2.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#35 from FoamyGuy/odb_api_update > Merge pull request adafruit/Adafruit_CircuitPython_SSD1680#33 from adafruit/tricolor_2point9 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_AS5600
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14
Follows what the comment from @jerryneedell said, moves the assertion call to just before the
self.fill_fifo()call, and assertspayloadinstead ofdata