Skip to content

Toss out chunked data if we never read anything #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

Toss out chunked data if we never read anything #44

merged 1 commit into from
Oct 30, 2020

Conversation

ladyada
Copy link
Member

@ladyada ladyada commented Oct 29, 2020

we dont know how much is remaining if data is chunked, so avoid comparing None received

@ladyada
Toss out chunked data if we never read anything
c8adb21 
we dont know how much is remaining if data is chunked!
@ladyada ladyada requested a review from tannewt October 29, 2020 22:51
makermelissa
makermelissa approved these changes Oct 30, 2020
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tannewt
Copy link
Member

tannewt commented Oct 30, 2020

Just saw this. I have the same fix in another PR with unit tests. Will merge this and leave the other PR for the tests. Thanks!

@tannewt tannewt merged commit 7d0e3ba into master Oct 30, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 31, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@c01bb3a)
f5bf093 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.6.1 from 1.6.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#27 from brentru/add-particle-shield

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.8.4 from 1.8.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#36 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.4 from 1.7.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#44 from adafruit/ladyada-patch-1
@evaherrada evaherrada deleted the ladyada-patch-1 branch June 21, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

@tannewt tannewt Awaiting requested review from tannewt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladyada @tannewt @makermelissa