Skip to content

Catch recv-into exception to prevent Out of sockets #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Catch recv-into exception to prevent Out of sockets #72

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6567d20
Catch recv-Into exception
anecdata Feb 6, 2021
10eebbd
Add string to OutOfRetries exception
anecdata Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions adafruit_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,15 +569,18 @@ def request(
result = socket.recv(1)
else:
result = bytearray(1)
socket.recv_into(result)
try:
socket.recv_into(result)
except OSError:
pass
if result == b"H":
# Things seem to be ok so break with socket set.
break
self._close_socket(socket)
socket = None

if not socket:
raise OutOfRetries()
raise OutOfRetries("Repeated socket failures")

resp = Response(socket, self) # our response
if "location" in resp.headers and 300 <= resp.status_code <= 399:
Expand Down