fallback types #95
Closed
fallback types #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anecdata
reviewed
Jan 9, 2022
|
Closing this. As discussed "in the weeds" during the meeting 1/10/21 the plan will be to remove the requirements and define interfaces for the types that are coming from them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If certain imports used for typing are missing, these custom TypeVars can end up not being defined which causes sphinx to fail to build with them ex: https://github.com/adafruit/Adafruit_CircuitPython_FunHouse/pull/28/checks
This change provides minimal fallbacks for those types so that sphinx build will complete in this case.