Skip to content

Update _reset for MCP2221 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2021
Merged

Update _reset for MCP2221 #8

merged 1 commit into from
Aug 27, 2021

Conversation

caternuson
Copy link
Contributor

For #7.

Basically just adding exception type that gets thrown for MCP2221 case.

(blinka) hellokitty@bench:~/repos/Adafruit_CircuitPython_SGP40$ python3
Python 3.8.10 (default, Jun  2 2021, 10:49:15) 
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import board
>>> import adafruit_sgp40
>>> sgp = adafruit_sgp40.SGP40(board.I2C())
>>> sgp.raw
2
>>> sgp.raw
24895
>>> sgp.raw
25563
>>>

@caternuson
Copy link
Contributor Author

@ladyada just had another idea - could also change exception thrown by MCP2221 to match CP?

So change this:
https://github.com/adafruit/Adafruit_Blinka/blob/4f4e6af0a2c2912d7662f0160849806507b125bd/src/adafruit_blinka/microcontroller/mcp2221/mcp2221.py#L233
to be an OSError to match here:
https://github.com/adafruit/circuitpython/blob/b36187102f17ab9031eeb9fb724c82b93d13ef42/shared-bindings/busio/I2C.c#L261

@ladyada
Copy link
Member

ladyada commented Aug 27, 2021

yah its a good idea to change the exception (also)!

@caternuson caternuson mentioned this pull request Aug 27, 2021
Open
@caternuson caternuson merged commit 3187395 into adafruit:main Aug 27, 2021
@caternuson caternuson mentioned this pull request Aug 27, 2021
Closed
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 1, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@f879b24)
0e6f5a3 
Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.2.1 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#8 from caternuson/iss7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caternuson @ladyada