Skip to content

Correct Missing Type Annotations #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 23, 2022
Merged

Correct Missing Type Annotations #10

merged 6 commits into from
Aug 23, 2022

Conversation

tcfranks
Copy link
Contributor

No description provided.

@tcfranks
Copy link
Contributor Author

ready for review / comments

@ladyada ladyada requested a review from tekktrik August 21, 2022 00:46
@tekktrik tekktrik linked an issue Aug 22, 2022 that may be closed by this pull request
Missing Type Annotations #9
Closed
5 tasks
@tekktrik tekktrik self-assigned this Aug 22, 2022
@tekktrik
Copy link
Member

tekktrik commented Aug 22, 2022 •
edited
Loading

I can take a look at this tonight, but see other libraries that use the CV class implementation for help on type annotating this: https://github.com/adafruit/Adafruit_CircuitPython_TLA202x/blob/main/adafruit_tla202x/__init__.py

tekktrik
tekktrik requested changes Aug 22, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good so far! I provided a link for help with type annotating the remaining parts.

@tcfranks
Copy link
Contributor Author

ready for re-review

tekktrik
tekktrik requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the remaining things! It looks like the base material was a little off or could be made slightly more specific here so a few changes for that.

tekktrik
tekktrik approved these changes Aug 23, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tekktrik tekktrik merged commit 6561561 into adafruit:main Aug 23, 2022
@tcfranks
Copy link
Contributor Author

review for prev comments

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Aug 24, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@d1e2132)
bb90d3b 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0398 to 1.1.14 from 1.1.13:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0398#13 from tcfranks/main
  > Use year duration range for copyright attribution
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT4x to 1.0.13 from 1.0.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT4x#10 from tcfranks/main
  > Keep copyright up to date in documentation

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Added the following libraries: Adafruit_CircuitPython_GUVX_I2C, Adafruit_CircuitPython_TCA8418
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees

@tekktrik tekktrik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @tekktrik