Skip to content

Fix compatibility with MicroPython #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Fix compatibility with MicroPython #78

merged 1 commit into from
Oct 9, 2022

Conversation

tekktrik
Copy link
Member

@tekktrik tekktrik commented Oct 7, 2022

Fixes #77 which is caused by the fact that the format must be specified for MicroPython, but not CircuitPython.

Links to docs for reference:
MicroPython framebuf.FrameBuffer
CircuitPython adafruit_framebuf.FrameBuffer

@tekktrik tekktrik requested a review from a team October 7, 2022 19:19
Copy link
Member

@gamblor21 gamblor21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I won't merge it if you want to wait until the original person in the issue tests it. Or merge it if you think it is good.

@tekktrik
Copy link
Member Author

tekktrik commented Oct 9, 2022

Looks like it fixed their problem!

@tekktrik tekktrik merged commit 70fd5fd into adafruit:main Oct 9, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adafruit_SSD1306 library not working on micropython with blinka
2 participants