Skip to content

Fix i2c parameter documentation #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 30, 2023
Merged

Fix i2c parameter documentation #49

merged 4 commits into from
Jul 30, 2023

Conversation

spovlot
Copy link
Contributor

@spovlot spovlot commented May 22, 2023

No description provided.

spovlot added 2 commits May 22, 2023 14:32
@spovlot
Update the i2c parameter documentation
42c8bae 
Fix the code documentation which was incorrect.
@spovlot
Minor text change
7786865
@tekktrik
Copy link
Member

Just wanted to say that you can ignore the warning about the exceptions, I'll fix that this week. The "line too long" one should get fixed however.

tekktrik
tekktrik requested changes May 30, 2023
View reviewed changes
@tekktrik
Copy link
Member

Looks like running pre-commit (specifically black) one last time should fix it now!

@spovlot
Copy link
Contributor Author

spovlot commented May 30, 2023

Seems to still be an issue. I will run "black" locally and update the code.

FoamyGuy
FoamyGuy approved these changes Jul 30, 2023
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @spovlot!

@FoamyGuy FoamyGuy merged commit 4a4305e into adafruit:main Jul 30, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 31, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@012b13e)
d0f92d1 
Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.19 from 1.0.18:
  > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#13 from sdomoszlai13/type_annotations

Updating https://github.com/adafruit/Adafruit_CircuitPython_SCD4X to 1.4.0 from 1.3.9:
  > Merge pull request adafruit/Adafruit_CircuitPython_SCD4X#7 from KeithTheEE/add_one_shot_co2

Updating https://github.com/adafruit/Adafruit_CircuitPython_ServoKit to 1.3.15 from 1.3.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_ServoKit#49 from spovlot/fix-i2c-doc

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik requested changes

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spovlot @tekktrik @FoamyGuy