added font file #14
Merged
added font file #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamblor21
reviewed
Sep 30, 2020
There was a problem hiding this comment.
I tried this on my Sharp Display and it works.
But I noticed the error comes from adafruit_framebuf.py which has a default name for text font (font5x8.bin). This file is included in the adafruit_framebuf examples folder so I am not sure how the build script for the library bundle will react to having it in both locations? (don't have the tools to build the bundle installed yet).
I did verify the font5x8.bin file exists in the 6.x bundle in the examples folder.
|
@makermelissa What do you think? |
|
@tannewt It's because this library is built on top of framebuf. I think it would probably help folks to include the font file. It's not like it really changes at all where we'd have to update it in multiple places. |
makermelissa
approved these changes
Oct 1, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 6, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.4 from 5.1.3: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#62 from adafruit/docs_fix-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_MS8607 to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_MS8607#4 from caternuson/typo Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.4.1 from 3.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#85 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_SharpMemoryDisplay to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_SharpMemoryDisplay#14 from ThomasBurgess2000/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The font file necessary to run the sharpmemorydisplay_simpletest.py was not present in the examples directory.