Skip to content

Update simpleio.tone to match 3.x audioio api #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kattni opened this issue Oct 2, 2018 · 2 comments
Closed

Update simpleio.tone to match 3.x audioio api #35

kattni opened this issue Oct 2, 2018 · 2 comments
Assignees
Labels

Comments

@kattni
Copy link
Contributor

kattni commented Oct 2, 2018

simpleio.tone is using a previous audioio API. We need to update it to check the version number, use the 3.x+ audioio API, and if it finds 2.x, to use the previous API. See https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground/blob/master/adafruit_circuitplayground/express.py#L622 for an example of using version numbers to utilise multiple APIs in a single funciton.

The issue is here: https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO/blob/master/simpleio.py#L57

This will need to be tested by using simpleio.tone to produce a tone using a non-PWM pin.

@caternuson
Copy link

See #36

@kattni
Copy link
Contributor Author

kattni commented Oct 3, 2018

Fixed, thank you!

@kattni kattni closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants