Make microseconds_to_angle() consistent with simpleio.Servo() #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- simpleio.Servo() allows for the fine tuning of pulse length via min_pulse and max_pulse but microseconds_to_angle() formerly ignored those values and used hard coded ones. - That would lead to an inaccurate conversion if fine tuning had been used. - This patch makes use of self.min_pulse and self.max_pulse in order to make correct use of any fine tuning specified during object instantiation.
Docstring erroneously stated that units were in microseconds when they were in fact milliseconds. This patch corrects that.
brentru
approved these changes
Aug 14, 2018
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 3, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 2.0.3 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#41 from caternuson/iss40 > ignore the board module imports in .pylintrc > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#38 from kattni/pylint-fix > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_HCSR04 to 0.3.3 from 0.3.2: > Try a new encrypted password Updating https://github.com/adafruit/Adafruit_CircuitPython_LIDARLite to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_LIDARLite#2 from kattni/pypi-setup Updating https://github.com/adafruit/Adafruit_CircuitPython_MLX90614 to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MLX90614#9 from kattni/pypi-setup > ignore the board module imports in .pylintrc > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.1.1 from 0.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#3 from kattni/pypi-setup Updating https://github.com/adafruit/Adafruit_CircuitPython_miniQR to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_miniQR#3 from kattni/pypi-setup Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleIO to 1.1.1 from 1.1.0: > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#36 from caternuson/iss35 > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#34 from brentru/remove-servo > Merge pull request adafruit/Adafruit_CircuitPython_SimpleIO#32 from ScottDWebster/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
min_pulse and max_pulse but microseconds_to_angle() formerly
ignored those values and used hard coded ones.
been used.
order to make correct use of any fine tuning specified during
object instantiation.