Added alignment for images smaller/larger than display #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FoamyGuy
approved these changes
Sep 22, 2020
There was a problem hiding this comment.
I tested this successfully with a PyPortal on 6.0.0-beta.0
The different positioning alignments are working correctly. Code looks good to me as well.
I think it would be great if we could either include one extra example script showing this functionality or modify the existing simpletest to make use of the new parameters. I don't think it is worth holding up this PR over that though.
|
Thanks for testing @FoamyGuy, we can create an issue for that, but an upcoming guide will be making use of it too. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 24, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO08X_RVC to 1.0.1 from 1.0.0: > fixed heading order Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.5.0 from 1.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#23 from kevinaj/fix_ip_host > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#21 from jepler/remove-bad-whitespace-directive Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 4.0.1 from 4.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#49 from askpatrickw/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.3.0 from 1.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#21 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BNO08X, Adafruit_CircuitPython_BNO08X_RVC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As needed for a JP demo.