Skip to content

use filename for OnDiskBitmap #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2021
Merged

use filename for OnDiskBitmap #41

merged 1 commit into from
Dec 7, 2021

Conversation

dhalbert
Copy link
Contributor

@dhalbert dhalbert commented Dec 7, 2021 •
edited
Loading

Fixes #40.

Pass a filename instead of an open file to OnDiskBitmap(). Similar fix to adafruit/Adafruit_CircuitPython_PortalBase#53.

Also reorder redisplay and fade up to prevent a minor redisplay glitch on the very first picture. Now it displays smoothly.

Tested on a PyPortal. Text .json files tested too.

@dhalbert dhalbert requested a review from a team December 7, 2021 14:30
@dhalbert dhalbert force-pushed the OnDiskBitmap-filename branch from 0e41476 to 9f4a5f8 Compare December 7, 2021 14:35
FoamyGuy
FoamyGuy approved these changes Dec 7, 2021
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Looks good to me. Tested with simpletest using both images and text json on:

Adafruit CircuitPython 7.1.0-beta.0 on 2021-11-12; Adafruit PyPortal with samd51j20
Board ID:pyportal

@FoamyGuy FoamyGuy merged commit cbeb32a into adafruit:main Dec 7, 2021
@dhalbert dhalbert deleted the OnDiskBitmap-filename branch December 7, 2021 15:11
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 8, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@628f852)
cee220c 
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.13 from 3.5.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#131 from adafruit/anecdata-patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#145 from dhalbert/make-package
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.9 from 2.4.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#27 from FoamyGuy/typing_fix
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.7.2 from 1.7.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#41 from dhalbert/OnDiskBitmap-filename
  > update rtd py version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix blank images
2 participants
@dhalbert @FoamyGuy