Skip to content

Add Missing Type Annotations #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Add Missing Type Annotations #40

merged 2 commits into from
Sep 29, 2022

Conversation

tcfranks
Copy link
Contributor

resolves #36
submitted for review / comment

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @tcfranks. I have one tweak to the imports. But rest of this is looking good to me

@tcfranks
Copy link
Contributor Author

resubmitted with changes

Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since it looks like the issues brought up by @FoamyGuy were addressed, thanks both of you!

@tekktrik tekktrik merged commit 7929b0b into adafruit:main Sep 29, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Sep 30, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_HT16K33 to 4.5.5 from 4.5.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#106 from tekktrik/doc/fix-example
  > Merge pull request adafruit/Adafruit_CircuitPython_HT16K33#107 from kattni/14-segment-example

Updating https://github.com/adafruit/Adafruit_CircuitPython_L3GD20 to 2.3.15 from 2.3.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_L3GD20#27 from tcfranks/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.6.4 from 0.6.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#40 from tcfranks/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
3 participants