set speaker and headphone volume levels during init. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Aug 20, 2025
There was a problem hiding this comment.
I think there is something wrong with the speaker volume getter or setter:
>>> t = adafruit_tlv320.TLV320DAC3100(board.I2C())
>>> t.speaker_volume
63.1579
>>> t.speaker_volume = -15
>>> t.speaker_volume
-15.7895
>>> t.headphone_volume
-63.5
>>> t.headphone_volume = -15
>>> t.headphone_volume
-15.0 # looks ok
>>> t.speaker_volume = 0
>>> t.speaker_volume
0.0
>>> t.speaker_volume = 63.1579
>>> t.speaker_volume
0.0 # hunh?
>>> t.speaker_volume = 50
>>> t.speaker_volume
0.0
>>> t.speaker_volume = 20
>>> t.speaker_volume
0.0|
The |
|
closing in favor of #10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed by default that
speaker_volumeafter DAC init is63.1579which is outside the range specified by thespeaker_volumeproperty.I don't think this setting is actually taking effect because the sound output from the speaker is still fairly quiet.
However I think it's best to explicitly set both of these to a value we know is safe for the speakers that are stocked in the shop. Both to avoid any potential damage to hardware, and to make it less confusing if anyone happens to check the value of and assumes that the value it returns will be valid for passing back to it to be set.