Catch Negative Values During Checks #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kattni
suggested changes
Jun 14, 2018
adafruit_trellis.py
Outdated
| @@ -172,7 +172,7 @@ def blink_rate(self): | |||
|
|
|||
| @blink_rate.setter | |||
| def blink_rate(self, rate): | |||
| if 0 < rate > 3: | |||
| if not 0 < rate > 3: | |||
There was a problem hiding this comment.
What are the acceptable values? Here, if rate is between 0 and 3, it will fail. So, are the acceptable rates all less than 0 and greater than 3?
Consider trying if not 0 <= rate <= 3:.
There was a problem hiding this comment.
The acceptable range is 0 to 3. So yes, this would definitely fail that test. Update coming in a few!
adafruit_trellis.py
Outdated
| @@ -188,7 +188,7 @@ def brightness(self): | |||
|
|
|||
| @brightness.setter | |||
| def brightness(self, brightness): | |||
| if 0 < brightness > 15: | |||
| if not 0 < brightness > 15: | |||
There was a problem hiding this comment.
Same as above. Is brightness always greater than 15?
There was a problem hiding this comment.
Range is 0 to 15.
…w and above range as errors.
tannewt
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Aug 9, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#3 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC59711 to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#3 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_TLC59711#2 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_Trellis to 1.1.0 from 1.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Trellis#8 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_Trellis#7 from sommersoft/val_checks > Merge pull request adafruit/Adafruit_CircuitPython_Trellis#5 from sommersoft/bytearray_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2561 to 3.1.1 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#16 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#15 from caternuson/master > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#14 from sommersoft/new_docs > Merge pull request adafruit/Adafruit_CircuitPython_TSL2561#13 from caternuson/master Updating https://github.com/adafruit/Adafruit_CircuitPython_TSL2591 to 1.1.0 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_TSL2591#4 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 3.1.0 from 3.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#4 from kattni/pypi > updated CoC Updating https://github.com/adafruit/Adafruit_CircuitPython_VCNL4010 to 0.9.0 from 0.8.1: > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VCNL4010#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_VEML6070 to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VEML6070#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_VL53L0X to 3.1.0 from 3.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VL53L0X#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_VL6180X to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#4 from kattni/pypi > updated CoC > Merge pull request adafruit/Adafruit_CircuitPython_VL6180X#3 from sommersoft/new_docs Updating https://github.com/adafruit/Adafruit_CircuitPython_WS2801 to 0.9.0 from 0.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_WS2801#2 from kattni/pypi > updated CoC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #6.