Breaking changes to conform to design guide #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Apr 22, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 6.0.0 from 5.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#25 from tekktrik/dev/convert-to-properties Updating https://github.com/adafruit/Adafruit_CircuitPython_Motor to 3.4.0 from 3.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_Motor#63 from tekktrik/dev/allow-pwmio-protocols > Update Black to latest. > Fixed readthedocs build > Consolidate Documentation sections of README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes resolve #24 by turning methods into properties. This seems to be more inline with the design guide for CircuitPython, since these seem to be more like "states" as opposed to "actions".
It doesn't look like the product tutorial needs any changing, since it didn't go over motion detection.