Skip to content

Update rotary examples #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2021
Merged

Update rotary examples #75

merged 1 commit into from
Jun 11, 2021

Conversation

jfurcean
Copy link
Contributor

This updates the rotary examples to:

  1. match imports and setup
  2. adds negation so that the encoder position increments when rotated clockwise.
  3. adds a pull up to the button pin per the forum suggestion - https://forums.adafruit.com/viewtopic.php?f=19&t=179100#p873311

@ladyada ladyada merged commit 4ab8a0f into adafruit:main Jun 11, 2021
@ladyada
Copy link
Member

ladyada commented Jun 11, 2021

thank you :)

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 15, 2021
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@bf03aa8)
2debb50 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BME280 to 2.6.6 from 2.6.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BME280#54 from jposada202020/aligning_example_code

Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.9.2 from 1.9.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#75 from jfurcean/negate-rotation

Updating https://github.com/adafruit/Adafruit_CircuitPython_AdafruitIO to 5.3.1 from 5.3.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_AdafruitIO#74 from adafruit/regex-fix
  > Moved default branch to main
  > Moved CI to Python 3.7
  > Added help text and problem matcher
  > Added pull request template

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.14.3 from 0.14.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#52 from FoamyGuy/remove_readinot_fallback
@ladyada ladyada mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfurcean @ladyada