Remove cp 6 fallback #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 23, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 4.0.2 from 4.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#157 from Neradoc/patch-1 > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_INA260 to 1.3.4 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_INA260#19 from gpongelli/patch-2 > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM6DS to 4.3.0 from 4.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_LSM6DS#49 from myllyja/add-lsm6ds3 > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 5.1.8 from 5.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#86 from tekktrik/hotfix/require-python-version-pt2 Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.2.2 from 5.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#103 from tekktrik/doc/minor-updates > Fixed readthedocs build > Consolidate Documentation sections of README Updating https://github.com/adafruit/Adafruit_CircuitPython_turtle to 2.2.5 from 2.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_turtle#29 from FoamyGuy/remove_cp_6_fallback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes removes all pixel_shader CP 6 compatibility code. So moving forward the library is compatible with CP 7+ only.
I also removed the now-artificial limit on number of things in the addon_group.
And changed the remaining instances of files being opened before passed to OnDiskBitmap() constructor to instead pass the filenames and let the file be managed internally.
Tested successfully with modified version of
turtle_bgpic_changeturtle.pyscript on PyPortal 7.2.0 rc0 as well as a few of the other fractal examples.